Checking dict keys fails #58

kellrott · 2019-05-17T21:45:26Z

In standard python

>>> x={"hello" : "world"}
>>> "hello" in x
True

In gpython

>>> x={"hello" : "world"}
>>> "hello" in x
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
    FIXME line of source goes here
TypeError: "unsupported operand type(s) for iter: 'dict'"

ncw · 2019-05-18T14:21:56Z

Implementing __iter__ for dict is very useful.

However for in to be efficient we should be implementing __contains__

gpython/py/sequence.go

Lines 121 to 147 in 61059b4

    
           // SequenceContains returns True if obj is in seq 
        
           func SequenceContains(seq, obj Object) (found bool, err error) { 
        
           	if I, ok := seq.(I__contains__); ok { 
        
           		result, err := I.M__contains__(obj) 
        
           		if err != nil { 
        
           			return false, err 
        
           		} 
        
           		return result == True, nil 
        
           	} else if result, ok, err := TypeCall1(seq, "__contains__", obj); ok { 
        
           		if err != nil { 
        
           			return false, err 
        
           		} 
        
           		return result == True, nil 
        
           	} 
        
           	var loopErr error 
        
           	err = Iterate(seq, func(item Object) bool { 
        
           		var eq Object 
        
           		eq, loopErr = Eq(item, obj) 
        
           		if loopErr != nil { 
        
           			return true 
        
           		} 
        
           		if eq == True { 
        
           			found = true 
        
           			return true 
        
           		} 
        
           		return false 
        
           	})

kellrott mentioned this issue May 17, 2019

Adding iterator method to Dict #59

Merged

corona10 mentioned this issue Jul 24, 2019

dict: Implement __contains__ of dict #65

Merged

Aug	SEP	Oct
	10
2019	2020	2021

go-python / gpython

Checking dict keys fails #58

Checking dict keys fails #58

kellrott commented May 17, 2019

ncw commented May 18, 2019

go-python / gpython

Join GitHub today

Checking dict keys fails #58

Checking dict keys fails #58

Comments

kellrott commented May 17, 2019

ncw commented May 18, 2019