The Wayback Machine - https://web.archive.org/web/20200912024113/https://github.com/CovenantSQL/CovenantSQL/pull/157
Skip to content

/ CovenantSQL

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP(S) Adapter Improvements and various query sanitizations #157

Merged
merged 14 commits into from Dec 27, 2018
Merged

HTTP(S) Adapter Improvements and various query sanitizations #157

merged 14 commits into from Dec 27, 2018

Conversation

@xq262144
Copy link
Contributor

xq262144 commented Dec 26, 2018

  1. Support http/unprivileged mode, easy for testing and POC.
  2. Support prepare statement and parameters in adapter query.
  3. Support application/json content-type request in query.
  4. Various query sanitization, including: sqlite special functions/internal tables/special queries.
  5. Slow query logging support.
  6. LevelDB storage page size adjustment.
xq262144 added 11 commits Dec 4, 2018
@xq262144
Add slow query log with a fixed 5 seconds slow query config
af490e8
@xq262144
Update sqlparser dependency
5b174f7
@xq262144
Update xenomint query filter to use ParseMulti instead of custom parsing
f7078dd
@xq262144
Ban all stateful query parts in sql statement
68dadf0
@xq262144
Add more function sanitization
9d3b1ad
@xq262144
Upgrade hash-upgrade command for xenomint version sqlchain
b3b77a5
@xq262144
Reduce leveldb page size
a7267bc
@xq262144
Prevent sqlite internal table from showing to users
6ab887a
@xq262144
Support query with bind parameters
5a262ee
@xq262144
Support http and unprivileged mode of adapter
61f5d5f
@xq262144
Query sanitization for DDL table name
Loading status checks…
fd02c3e
@xq262144 xq262144 force-pushed the feature/adapterQueryArgs branch from db37f43 to fd02c3e Dec 26, 2018
@CovenantSQL CovenantSQL deleted a comment from codecov bot Dec 26, 2018
@CovenantSQL CovenantSQL deleted a comment from codecov bot Dec 26, 2018
@codecov
Copy link

codecov bot commented Dec 26, 2018 •
edited

Codecov Report

Merging #157 into develop will increase coverage by 0.31%.
The diff coverage is 84.96%.

@@             Coverage Diff             @@
##           develop     #157      +/-   ##
===========================================
+ Coverage    76.63%   76.95%   +0.31%     
===========================================
  Files          146      147       +1     
  Lines        10916    11100     +184     
===========================================
+ Hits          8366     8542     +176     
+ Misses        1860     1859       -1     
- Partials       690      699       +9
@auxten
auxten reviewed Dec 26, 2018
View changes
xenomint/query_sanitizer.go Outdated Show resolved Hide resolved
@leventeliu
leventeliu reviewed Dec 26, 2018
View changes
xenomint/query_sanitizer.go Outdated Show resolved Hide resolved
@xq262144
Use Wrap as Wrapf
Loading status checks…
1d33e3f
@leventeliu
leventeliu approved these changes Dec 26, 2018
View changes
Copy link
Contributor

leventeliu left a comment

LGTM, approve.
xq262144 added 2 commits Dec 26, 2018
@xq262144
Use backtick instead of double quote for long sql statement
Loading status checks…
90f1ce1
@xq262144
Merge branch 'develop' into feature/adapterQueryArgs
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c655749
@auxten
auxten approved these changes Dec 27, 2018
View changes
Copy link
Contributor

auxten left a comment

LGTM
@auxten auxten merged commit 4ef9906 into develop Dec 27, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@leventeliu leventeliu deleted the feature/adapterQueryArgs branch Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auxten auxten

@leventeliu leventeliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@xq262144 @auxten @leventeliu
You can’t perform that action at this time.