The Wayback Machine - https://web.archive.org/web/20200912024214/https://github.com/CovenantSQL/CovenantSQL/pull/182
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue: duplicate branches #182

Merged
merged 1 commit into from Jan 3, 2019
Merged

Fix issue: duplicate branches #182

merged 1 commit into from Jan 3, 2019

Conversation

@leventeliu
Copy link
Contributor

leventeliu commented Jan 3, 2019

A duplicate block check should be done before any further check, or it may produce a duplicate branch.

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #182 into develop will decrease coverage by 0.17%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #182      +/-   ##
===========================================
- Coverage    77.13%   76.95%   -0.18%     
===========================================
  Files          135      135              
  Lines        10770    10771       +1     
===========================================
- Hits          8307     8289      -18     
- Misses        1821     1836      +15     
- Partials       642      646       +4
1 similar comment
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #182 into develop will decrease coverage by 0.17%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #182      +/-   ##
===========================================
- Coverage    77.13%   76.95%   -0.18%     
===========================================
  Files          135      135              
  Lines        10770    10771       +1     
===========================================
- Hits          8307     8289      -18     
- Misses        1821     1836      +15     
- Partials       642      646       +4
@auxten
auxten approved these changes Jan 3, 2019
Copy link
Contributor

auxten left a comment

LGTM

Copy link
Contributor

zeqing-guo left a comment

Approve

@zeqing-guo zeqing-guo merged commit 09ee7bb into develop Jan 3, 2019
4 checks passed
4 checks passed
ci/gitlab/gitlab.com Pipeline passed on GitLab
Details
codecov/project Absolute coverage decreased by -0.17% but relative coverage increased by +22.86% compared to bd8aea5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@zeqing-guo zeqing-guo deleted the bugfix/duplicate branch Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.