The Wayback Machine - https://web.archive.org/web/20200912024301/https://github.com/CovenantSQL/CovenantSQL/pull/217
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block producer genesis block hash mismatch #217

Merged
merged 6 commits into from Jan 17, 2019
Merged

Fix block producer genesis block hash mismatch #217

merged 6 commits into from Jan 17, 2019

Conversation

@leventeliu
Copy link
Contributor

leventeliu commented Jan 15, 2019

  • Use standard verifier.DefaultHashSignVerifierImpl in BPBlock instead of the old implementation.
  • Split Sign and Verify methods of verifier interface into SetHash, SignHash, VerifyHash, and VerifySignature.
  • Use SetHash to rewrite genesis block hash on cqld bootstrap, and use VerifyHash to verify it in the main chain.
leventeliu added 5 commits Jan 15, 2019
@CovenantSQL CovenantSQL deleted a comment from codecov bot Jan 15, 2019
@CovenantSQL CovenantSQL deleted a comment from codecov bot Jan 15, 2019
@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #217 into beta will increase coverage by 0.13%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             beta     #217      +/-   ##
==========================================
+ Coverage   76.27%   76.41%   +0.13%     
==========================================
  Files         136      136              
  Lines       11230    11247      +17     
==========================================
+ Hits         8566     8594      +28     
+ Misses       2005     1999       -6     
+ Partials      659      654       -5
@leventeliu leventeliu changed the base branch from develop to beta Jan 15, 2019
@leventeliu leventeliu changed the title [WIP] Fix block producer genesis block hash mismatch Fix block producer genesis block hash mismatch Jan 17, 2019
Copy link
Contributor

xq262144 left a comment

Approve

@auxten
auxten approved these changes Jan 17, 2019
Copy link
Contributor

auxten left a comment

LGTM

@auxten auxten merged commit 6026fab into beta Jan 17, 2019
4 checks passed
4 checks passed
ci/gitlab/gitlab.com Pipeline passed on GitLab
Details
codecov/project 76.41% (+0.13%) compared to f37c373
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@leventeliu leventeliu deleted the bugfix/startup branch Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.