The Wayback Machine - https://web.archive.org/web/20200912024419/https://github.com/CovenantSQL/CovenantSQL/pull/269
Skip to content

/ CovenantSQL

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add previous version compatibility test #269

Merged
merged 31 commits into from Feb 28, 2019
Merged

Add previous version compatibility test #269

merged 31 commits into from Feb 28, 2019

Conversation

@laodouya
Copy link
Contributor

laodouya commented Feb 28, 2019

  1. Add old bp/miner/client compatibility test
  2. Use common volumes in host for build bins
laodouya added 23 commits Feb 25, 2019
@laodouya
Add param for test old client.
2c7b406
@laodouya
Add start_bp_miner for makefile, Add test old clinet task.
bb59b5f
@laodouya
Fix test old client case missing param set bug.
572160f
@laodouya
Try using build docker with docker command.
Loading status checks…
a5e6baa
@laodouya
Revert compatibility test docker build.
Loading status checks…
5061e5c
@laodouya
Let testnet_client only run testnet.
Loading status checks…
b767b94
@laodouya
Add test old clinet to current bp miner test.
Loading status checks…
459bd53
@laodouya
Make bp miner bin before compatibility test.
Loading status checks…
b0972cc
@laodouya
Make compatibility test bp and miner running background
Loading status checks…
5435557
@laodouya
Fix bp miner not running background.
Loading status checks…
b5232b8
@laodouya
Fix compatibility test, wait for miner start.
Loading status checks…
223975c
@laodouya
Increase integration miner client init stable coin count.
Loading status checks…
24a2a9e
@laodouya
Increase compatibility test wait bp miner time.
Loading status checks…
cdb9222
@laodouya
Disable other ci test.
5a00d66
@laodouya
Fail compatibility test if dsn not created.
Loading status checks…
8349f4c
@laodouya
Fix compatibility test miner config.
Loading status checks…
70d1914
@laodouya
Revert "Disable other ci test."
2978a94 
This reverts commit 5a00d66.
@laodouya
Add ci build stage, reuse build result in test stage.
Loading status checks…
bf1eafd
@laodouya
Add old bp, old miner case for compatibility test.
Loading status checks…
fbdbda4
@laodouya
Rename gitlab ci task name.
Loading status checks…
9197878
@laodouya
Fix compatibility miner bin name wrong.
Loading status checks…
1112e67
@laodouya
Seperate logs for different compatibility test case.
61085a6
@laodouya
Update prev bin version to v0.4.0
Loading status checks…
2d080b5
@laodouya laodouya requested review from auxten, leventeliu and xq262144 Feb 28, 2019
@codecov
Copy link

codecov bot commented Feb 28, 2019 •
edited

Codecov Report

Merging #269 into develop will decrease coverage by 0.5%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #269      +/-   ##
===========================================
- Coverage    80.96%   80.45%   -0.51%     
===========================================
  Files          159      159              
  Lines        11914    11914              
===========================================
- Hits          9646     9586      -60     
- Misses        1580     1635      +55     
- Partials       688      693       +5
@leventeliu
leventeliu reviewed Feb 28, 2019
View changes
test/compatibility/specific_old.sh Outdated Show resolved Hide resolved
@xq262144
xq262144 reviewed Feb 28, 2019
View changes
.gitlab-ci.yml Outdated Show resolved Hide resolved
@laodouya
Use a independent cache folder for each ci jobs.
e2a5551
laodouya added 5 commits Feb 28, 2019
@laodouya
Redirect compatibility test bp, miner stdout to files.
Loading status checks…
2c757ac
@laodouya
Create job cache dir if not exist for gitlabci.
Loading status checks…
0607ef2
@laodouya
Use CI_PIPELINE_IID instead of CI_JOB_ID for transfer cache dir.
Loading status checks…
5c299e2
@laodouya
Seperate cache bin dir and log dir.
Loading status checks…
10a16c7
@laodouya
Remove all cache folder while ci success.
Loading status checks…
7a95e63
@laodouya laodouya force-pushed the feature/compatibility branch 2 times, most recently from b657eb2 to 13b1951 Feb 28, 2019
@laodouya
Combine ci cleanup process.
Loading status checks…
7aef69d
@laodouya laodouya force-pushed the feature/compatibility branch from 13b1951 to 7aef69d Feb 28, 2019
@laodouya laodouya requested review from xq262144 and leventeliu Feb 28, 2019
@xq262144
xq262144 reviewed Feb 28, 2019
View changes
.gitlab-ci.yml Outdated Show resolved Hide resolved
@laodouya
Use independent config file for compatibility test.
Loading status checks…
3451b40
@xq262144
xq262144 approved these changes Feb 28, 2019
View changes
Copy link
Contributor

xq262144 left a comment

Approve
@leventeliu
leventeliu approved these changes Feb 28, 2019
View changes
Copy link
Contributor

leventeliu left a comment

LGTM.
@leventeliu leventeliu merged commit 895721b into develop Feb 28, 2019
3 of 4 checks passed
3 of 4 checks passed
codecov/project 80.45% (-0.51%) compared to 2e4563a
Details
ci/gitlab/gitlab.com Pipeline passed on GitLab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@leventeliu leventeliu deleted the feature/compatibility branch Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xq262144 xq262144

@leventeliu leventeliu

@auxten auxten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@laodouya @xq262144 @leventeliu
You can’t perform that action at this time.