The Wayback Machine - https://web.archive.org/web/20200912024658/https://github.com/CovenantSQL/CovenantSQL/pull/346
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account type IsValid bug. #346

Merged
merged 1 commit into from May 23, 2019
Merged

Fix account type IsValid bug. #346

merged 1 commit into from May 23, 2019

Conversation

@laodouya
Copy link
Contributor

laodouya commented May 23, 2019

No description provided.

Copy link
Contributor

leventeliu left a comment

OK.

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #346 into develop will decrease coverage by 0.21%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #346      +/-   ##
===========================================
- Coverage    80.57%   80.35%   -0.22%     
===========================================
  Files          174      174              
  Lines        12344    12344              
===========================================
- Hits          9946     9919      -27     
- Misses        1662     1689      +27     
  Partials       736      736
1 similar comment
@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #346 into develop will decrease coverage by 0.21%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #346      +/-   ##
===========================================
- Coverage    80.57%   80.35%   -0.22%     
===========================================
  Files          174      174              
  Lines        12344    12344              
===========================================
- Hits          9946     9919      -27     
- Misses        1662     1689      +27     
  Partials       736      736
@auxten
auxten approved these changes May 23, 2019
Copy link
Contributor

auxten left a comment

LGTM

@auxten auxten merged commit d3aa40e into develop May 23, 2019
4 checks passed
4 checks passed
ci/gitlab/gitlab.com Pipeline passed on GitLab
Details
codecov/project Absolute coverage decreased by -0.21% but relative coverage increased by +19.42% compared to 22cd2ad
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@laodouya laodouya deleted the bugfix/account_type branch May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.