The Wayback Machine - https://web.archive.org/web/20200912024627/https://github.com/CovenantSQL/CovenantSQL/pull/339
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support double quote ident for table/column name #339

Merged
merged 6 commits into from May 21, 2019

Conversation

@xq262144
Copy link
Contributor

xq262144 commented May 16, 2019

No description provided.

xq262144 added 2 commits May 16, 2019
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #339 into develop will decrease coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop     #339     +/-   ##
==========================================
- Coverage    81.03%   80.53%   -0.5%     
==========================================
  Files          174      174             
  Lines        12336    12336             
==========================================
- Hits          9996     9935     -61     
- Misses        1603     1665     +62     
+ Partials       737      736      -1
@auxten
Copy link
Contributor

auxten commented May 17, 2019

@laodouya laodouya requested review from leventeliu and auxten May 17, 2019
xq262144 and others added 3 commits May 20, 2019
Copy link
Contributor

leventeliu left a comment

LGTM.

@xq262144 xq262144 merged commit 63b337c into develop May 21, 2019
4 checks passed
4 checks passed
ci/gitlab/gitlab.com Pipeline passed on GitLab
Details
codecov/project 80.53% (-0.5%) compared to 7128df7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@xq262144 xq262144 deleted the feature/parser_double_quote_ident branch May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.