The Wayback Machine - https://web.archive.org/web/20200627234313/https://github.com/angular/angular/pull/36464
Skip to content

/ angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to latest version of yarn #36464

Closed
wants to merge 1 commit into from
Closed

build: update to latest version of yarn #36464

wants to merge 1 commit into from

Conversation

@josephperrott
Copy link
Member

josephperrott commented Apr 6, 2020

No description provided.

@josephperrott josephperrott requested a review from devversion Apr 6, 2020
@ngbot ngbot bot modified the milestone: needsTriage Apr 6, 2020
@googlebot googlebot added the cla: yes label Apr 6, 2020
@devversion
devversion approved these changes Apr 7, 2020
View changes
Copy link
Member

devversion left a comment •
edited

LGTM. Should we update version ranges in the package.json? Adding PR action: cleanup so you can react to my feedback.
@josephperrott
build: update to latest version of yarn
Loading status checks…
1679413
@josephperrott josephperrott force-pushed the josephperrott:yarn-update branch from a63d8ad to 1679413 Apr 7, 2020
@pullapprove pullapprove bot requested a review from IgorMinar Apr 7, 2020
@josephperrott
Copy link
Member Author

josephperrott commented Apr 7, 2020

@devversion I updated them

I am unsure of how we should be handling this since yarn should be doing the vendoring for us now, but it doesn't hurt to update it.
@devversion
Copy link
Member

devversion commented Apr 8, 2020 •
edited

@josephperrott Yeah, I'm not sure either. It sounds like we could just remove the range for Yarn (we can talk about this in the dev-infra sync; maybe there are concerns)
@atscott
Copy link
Contributor

atscott commented Apr 8, 2020

@josephperrott - Is this ready to merge? If so, can you please remove Igor from the reviewers list and/or add the merge assistance label if pullapprove is still not happy?
@atscott atscott closed this in b010849 Apr 14, 2020
atscott added a commit that referenced this pull request Apr 14, 2020
@josephperrott @atscott
build: update to latest version of yarn (#36464)
Loading status checks…
9399386 
PR Close #36464
kyliau added a commit to kyliau/angular-cli that referenced this pull request Apr 22, 2020
@kyliau
build: update to yarn 1.22.4
8ffb334 
This commit vendors yarn v1.22.4 into angular cli repo and updates yarnrc.

Reference PR: angular/angular#36464
@kyliau kyliau mentioned this pull request Apr 22, 2020
Merged
kyliau added a commit to kyliau/angular-cli that referenced this pull request Apr 22, 2020
@kyliau
build: update to yarn 1.22.4
45a52e9 
This commit vendors yarn v1.22.4 into angular cli repo and updates yarnrc.

Reference PR: angular/angular#36464
kyliau added a commit to angular/angular-cli that referenced this pull request Apr 22, 2020
@kyliau
build: update to yarn 1.22.4
Loading status checks…
871cf06 
This commit vendors yarn v1.22.4 into angular cli repo and updates yarnrc.

Reference PR: angular/angular#36464
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 15, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion

@IgorMinar IgorMinar

Assignees
No one assigned
Labels
PR action: merge PR action: merge-assistance PR target: master & patch cla: yes comp: build & ci
Projects
None yet
Milestone
  needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@josephperrott @devversion @atscott @googlebot
You can’t perform that action at this time.