Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport signing in Repository#mergeBranches #1664
Merged
Conversation
| ) { | ||
| const repo = this; | ||
| let fromBranch; | ||
| let toBranch; | ||
| processMergeMessageCallback = processMergeMessageCallback || | ||
| // Support old parameter `processMergeMessageCallback` | ||
| const isOldOptionParameter = typeof mergeBranchOptions === "function"; |
This comment has been minimized.
This comment has been minimized.
implausible
Apr 17, 2019
Member
Can you output a console.error warning that this parameter is deprecated and should be updated to the new object type?
This comment has been minimized.
This comment has been minimized.
implausible
Apr 17, 2019
Member
Any tests that use this method should also be updated to use the new parameter format.
ianhattendorf
force-pushed the
ianhattendorf:fix/repo-merge-sign
branch
from
c6dd470
to
17aca8c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ianhattendorf commentedApr 17, 2019
No description provided.