The Wayback Machine - https://web.archive.org/web/20200908165801/https://github.com/catalyst-team/catalyst/issues/682
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using an activation function of "Softmax2d" for many callbacks and losses, no argmax is applied #682

Open
jchen42703 opened this issue Mar 2, 2020 · 7 comments

Comments

@jchen42703
Copy link
Contributor

@jchen42703 jchen42703 commented Mar 2, 2020

(I will compile a list and hopefully open a PR if needed)

Describe the bug
This behavior is present in a plethora of catalyst's callbacks and losses. It's consistent, but it's definitely confusing for many new users.

To Reproduce
Steps to reproduce the behavior:
Use these functions/classes:
Callbacks

Criterion // Dependents

Expected behavior
Should ideally apply argmax when activation='Softmax2d'

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@jchen42703 jchen42703 added the bug label Mar 2, 2020
@Scitator
Copy link
Member

@Scitator Scitator commented Mar 24, 2020

Do you have a minimal example to reproduce the issue?

@Scitator
Copy link
Member

@Scitator Scitator commented Apr 22, 2020

Dear @jchen42703 ,
How are you doing? Does this issue is still valid? Do you have a proposal for a Pull Request contribution?

@jchen42703
Copy link
Contributor Author

@jchen42703 jchen42703 commented Apr 22, 2020

@Scitator Ahhhh sorry, I've been prioritizing work lately. I'll hopefully get to this by the end of next week. I think the PR should just be a warning for the next version and then the actual changes on the version after that.

@Scitator
Copy link
Member

@Scitator Scitator commented Apr 23, 2020

@jchen42703 Thank you!

@stale
Copy link

@stale stale bot commented Jun 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 22, 2020
@Scitator
Copy link
Member

@Scitator Scitator commented Jun 22, 2020

Dear @jchen42703 ,
Do you have any plans for this feature implementation?
Thanks in advance.

@stale stale bot removed the wontfix label Jun 22, 2020
@Scitator
Copy link
Member

@Scitator Scitator commented Jul 24, 2020

@jchen42703 👀 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.