The Wayback Machine - https://web.archive.org/web/20201009231221/https://github.com/AllAlgorithms/python/pull/58
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stack to data structures and unitary tests #58

Merged
merged 1 commit into from Oct 3, 2020

Conversation

@mauricio-chavez
Copy link
Contributor

@mauricio-chavez mauricio-chavez commented Oct 20, 2018

I have done a stack to you, so you can include it into your data structures directory, It contains a stack module and a node module, and also contains its respectively unitary tests. :octocat:

Copy link
Member

@abranhe abranhe left a comment

Thanks so much for your contribution to The All ▲lgorithms Project. Without people like you submitting Pull Requests we couldn't run this project, but there are changes must be done before merging this pull request.

  • Even though tests are one of the most important things in programming, here we rather add only the file with the algorithm implementation and a simple test on it, just to keep it simple.

Still, want to add tests? It's ok you can contribute to our Official Python Library, where you can include algorithms & must add also tests for it https://github.com/abranhe/allalgorithms-python.

One last but not less important thing: make sure you star ⭐️ those projects and follow @abranhe :)

@abranhe abranhe changed the title :octocat: Added stack to data structures and unitary tests Added stack to data structures and unitary tests Oct 25, 2018
@christianbender
Copy link
Collaborator

@christianbender christianbender commented Mar 3, 2019

@mauricio-chavez Please put you data-structure (and classes) in one file.

@abranhe abranhe merged commit f50dbcd into AllAlgorithms:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.