Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updocs(@angular/cli): fix schema.json description for `stylePreprocessorOptions.includePaths` #17156
Conversation
…ons` > `includePaths`
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
|
spenceryue
changed the title
spenceryue
changed the title
|
@googlebot I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! |
Previously, the
schema.jsondescription forstylePreprocessorOptions>includePathsspecified that paths were resolved with respect to "project root", but this should read "workspace root".Starting at styles.ts#L81,
each user-specified include path is resolved with respect to
root, declared at styles.ts#L27where
wcois passed in from the containing function,getStylesConfig, called at index.ts#L138inside the
webpackPartialGeneratorcallback, which was passed togenerateBrowserWebpackConfigFromContextat index.ts#L154which in turn passed the callback to
generateWebpackConfig, which calls the callback at webpack-browser-config.ts#L104with the
wcoobject declared at webpack-browser-config.ts#L91, which has itsrootfield set toworkspaceRootwhich was passed in from
generateBrowserWebpackConfigFromContextat webpack-browser-config.ts#L222 aswhere
workspaceRootwas declared at webpack-browser-config.ts#L204 asusing the
contextreceived from the caller,buildBrowserWebpackConfigFromContext, whose own caller,setup, passed in thecontextit received fromsetupWebpackBrowserwhich declares the type ofcontextto beBuilderContext, whose definition includes a comment for theworkspaceRootfield at api.ts#L146,motivating this PR.
It would probably also be helpful to also mention the include path resolution strategy in the relevant section of the docs.