Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
TestData: Remove useEffect that triggeres query on component load #28321
Conversation
torkelo
requested review from
jackw and
kaydelaney
and removed request for
grafana/grafana-frontend-platform
|
LGTM! |
| useEffect(() => { | ||
| onUpdate(query); | ||
| }, []); | ||
|
|
Clarity-89
Oct 19, 2020
Contributor
Hmm, strange, I remember the graphs weren't rendered properly on page reload after saving dashboard, so that's why I added this call on mount, but I just checked it again and it works without it too.
Hmm, strange, I remember the graphs weren't rendered properly on page reload after saving dashboard, so that's why I added this call on mount, but I just checked it again and it works without it too.
aknuds1
added a commit
that referenced
this pull request
Oct 21, 2020
…8321) * TestData: Remove useEffect that triggeres query on component load * Updated * Update e2e spec
ryantxu
added a commit
that referenced
this pull request
Nov 18, 2020
…8321) * TestData: Remove useEffect that triggeres query on component load * Updated * Update e2e spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes so that testdata does not issue queries when the query editor is loaded, and fixes so the scenario api is not called for every query