The Wayback Machine - https://web.archive.org/web/20210904204233/https://github.com/python/cpython/pull/23031
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42199: Fix bytecode_helper assertNotInBytecode #23031

Merged
merged 2 commits into from Dec 18, 2020

Conversation

@tekknolagi
Copy link
Contributor

@tekknolagi tekknolagi commented Oct 29, 2020

Ensure that the helper will only fail if the programmer provided an arg and it matches an instruction arg. Add tests.

https://bugs.python.org/issue42199

@tekknolagi tekknolagi force-pushed the tekknolagi:mb-fix-bytecode-helper branch from 2641bf3 to 58a04cf Oct 29, 2020
@tekknolagi
Copy link
Contributor Author

@tekknolagi tekknolagi commented Oct 29, 2020

This patch contributed by @DinoV.

@tekknolagi
Copy link
Contributor Author

@tekknolagi tekknolagi commented Oct 29, 2020

bytecode_helper.py moved from tests/ to tests/support/ at some point, so backporting this may not be as easy as cherry-picking.

@tekknolagi
Copy link
Contributor Author

@tekknolagi tekknolagi commented Oct 29, 2020

It turns out that git is pretty good at this kind of thing and cherry-picking really does work. So maybe the automated tooling will do just fine...

@github-actions
Copy link

@github-actions github-actions bot commented Dec 16, 2020

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale label Dec 16, 2020
@DinoV
DinoV approved these changes Dec 18, 2020
@DinoV DinoV merged commit 6e799be into python:master Dec 18, 2020
10 checks passed
10 checks passed
@github-actions
Docs
Details
@github-actions
Check for source changes
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
Azure Pipelines PR #20201029.33 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 42199 found
Details
@bedevere-bot
bedevere/news News entry found in Misc/NEWS.d
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 18, 2020

@DinoV: Please replace # with GH- in the commit message next time. Thanks!

@tekknolagi
Copy link
Contributor Author

@tekknolagi tekknolagi commented Dec 18, 2020

time to backport? :D

adorilson added a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
* bpo-42199: Fix bytecode_helper assertNotInBytecode

Add tests.

* 📜🤖 Added by blurb_it.

Co-authored-by: Dino Viehland <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants