The Wayback Machine - https://web.archive.org/web/20201112030801/https://github.com/HeroTransitions/Hero/pull/594
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update for swift 5 #594

Open
wants to merge 2 commits into
base: develop
from
Open

Conversation

@barrault01
Copy link

@barrault01 barrault01 commented Mar 27, 2019

Hello I run the xcode migration, I run the tests and they are passing.

@daniel-beard
Copy link

@daniel-beard daniel-beard commented Apr 3, 2019

Any chance of someone merging this one soon and getting a new cocoapods release?

@pauloec
Copy link

@pauloec pauloec commented Apr 11, 2019

Unlikely. The owner has left indefinitely.

@iosdevben
Copy link

@iosdevben iosdevben commented Apr 25, 2019

Thanks for doing the PR @barrault01. I've switched my Cartfile to point to your repo instead.

Copy link
Collaborator

@JoeMatt JoeMatt left a comment

Do we also need to add,

s.swift_version = '5.0'

to the Podspec?

@@ -0,0 +1,12 @@
# These are supported funding model platforms

This comment has been minimized.

@JoeMatt

JoeMatt Oct 7, 2019
Collaborator

Can we remove this from the PR and open another with it if it's wanted

@JoeMatt JoeMatt changed the base branch from master to develop Oct 7, 2019
@JoeMatt
Copy link
Collaborator

@JoeMatt JoeMatt commented Oct 8, 2019

.swift-version should be updated to 5.0 also.

@kuyazee
Copy link
Member

@kuyazee kuyazee commented Oct 8, 2019

.swift-version should be updated to 5.0 also.

Shouldn’t we remove the .swift-version file because of the specification in the Podspec?

@JoeMatt
Copy link
Collaborator

@JoeMatt JoeMatt commented Oct 8, 2019

.swift-version should be updated to 5.0 also.

Shouldn’t we remove the .swift-version file because of the specification in the Podspec?

I agree, .swift-version is considered deprecated by Cocoapods. Other tools may use it but it was never a standard for swift. Package.swift or the XCode project already reflect their compatible version.s

@kuyazee kuyazee self-requested a review Oct 8, 2019
@kuyazee
Copy link
Member

@kuyazee kuyazee commented Oct 8, 2019

.swift-version should be updated to 5.0 also.

Shouldn’t we remove the .swift-version file because of the specification in the Podspec?

I agree, .swift-version is considered deprecated by Cocoapods. Other tools may use it but it was never a standard for swift. Package.swift or the XCode project already reflect their compatible version.s

Ok then, once the .swift-version file is removed we can merge this PR. Thanks guys

@barrault01 barrault01 requested a review from JoeMatt Oct 12, 2019
@barrault01
Copy link
Author

@barrault01 barrault01 commented Oct 12, 2019

Guys going to close this pull request I just run the xcode migration, and now with Xcode 11 it is not building the tests anymore... I will let my repository available until someone migrate the lib to xcode 11 + Swift 5.

@barrault01 barrault01 closed this Oct 12, 2019
@JoeMatt
Copy link
Collaborator

@JoeMatt JoeMatt commented Oct 21, 2019

Reopening so we can build on this work

@JoeMatt JoeMatt reopened this Oct 21, 2019
@JoeMatt JoeMatt changed the title update for swift 5 [WIP] Update for swift 5 Oct 21, 2019
@JoeMatt JoeMatt added this to the 1.6.0 milestone Oct 29, 2019
@jdisho
Copy link

@jdisho jdisho commented Nov 12, 2019

What is the status of this PR? Is somebody working on?
If not, I would prefer taking it over.

@JoeMatt
Copy link
Collaborator

@JoeMatt JoeMatt commented Nov 17, 2019

What is the status of this PR? Is somebody working on?
If not, I would prefer taking it over.
@jdisho

You're welcome to copy this branch and make a new PR and reference this issue number #594. Looks like it just needs a rebase and conflict resolution.

@nick-potts nick-potts mentioned this pull request Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.