The Wayback Machine - https://web.archive.org/web/20201103183210/https://github.com/TheAlgorithms/Java/pull/1966
Skip to content

/ Java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkstyle action #1966

Closed
wants to merge 5 commits into from
Closed

Checkstyle action #1966

wants to merge 5 commits into from

Conversation

@shellhub
Copy link
Member

@shellhub shellhub commented Oct 27, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
shellhub added 2 commits Oct 27, 2020
@shellhub
fixed version
Loading status checks…
17861ac
@shellhub
fixed action
Loading status checks…
0f51f8b
@shellhub shellhub force-pushed the checkstyle branch from 4554d56 to 0f51f8b Oct 27, 2020
@shellhub shellhub changed the title Checkstyle Checkstyle action Oct 27, 2020
@shellhub
test
Loading status checks…
0f11486
@shellhub shellhub force-pushed the checkstyle branch from 16ecf45 to 0f11486 Oct 27, 2020
@shellhub
Copy link
Member Author

@shellhub shellhub commented Oct 27, 2020

@cclauss Can you help me fix this problem. I have changed version to v1 but it still not worked.
shellhub and others added 2 commits Nov 2, 2020
@shellhub
Update checkstyle.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f99d550
github-actions github-actions
Formatted with Google Java Formatter
Loading status checks…
fb2b1d0
@shellhub shellhub closed this Nov 2, 2020
@shellhub shellhub deleted the checkstyle branch Nov 2, 2020
@shellhub shellhub restored the checkstyle branch Nov 2, 2020
@shellhub shellhub deleted the checkstyle branch Nov 2, 2020
@cclauss
cclauss reviewed Nov 2, 2020
View changes
.github/workflows/checkstyle.yml
jobs:
format:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1 # v1, NOT v2
- uses: actions/checkout@master

This comment has been minimized.

Sign in to view
@cclauss

cclauss Nov 2, 2020
Member
  1. The actions/checkout repo uses main, not master as its principal branch so that it can be politically correct.
  2. The comment says that we want to use v1, not something later because we are pushing to a branch.
  3. Sweeping error conditions under the rug with || true is going to hide where problems arise in this process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@shellhub @cclauss
You can’t perform that action at this time.