The Wayback Machine - https://web.archive.org/web/20201106202609/https://github.com/python-gitlab/python-gitlab/pull/1215
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(users): force 10 seconds sleep to improve reliability #1215

Open
wants to merge 1 commit into
base: master
from

Conversation

@max-wittig
Copy link
Member

@max-wittig max-wittig commented Oct 12, 2020

I'm welcome for better ideas

time.sleep(10)
new_user.delete()
Comment on lines +57 to 58

This comment has been minimized.

@nejch

nejch Oct 13, 2020
Member

I think this should go after, because the delete itself is taking too long:

Suggested change
time.sleep(10)
new_user.delete()
new_user.delete()
time.sleep(10)

Looks like we really need this. I thought my little sidekiq wait hack would work though 🤕 I based it off of this, but I'm not sure if we can extract from the API when this exact sidekiq deletion job is finished:

We can't guarantee when the user will actually be deleted by Sidekiq; this could take a while if the user has a lot of projects/events/etc.

I'll keep looking into this later, maybe we could also just wrap these asserts in retries until the condition is met (with a timeout), since it seems to me like GitLab gets more bloated with new features and so things can take longer with new releases on these little Travis VMs?

They do perform better during the day/office hours though, just retried all the jobs and they're going green 🤣

This comment has been minimized.

@max-wittig

max-wittig Oct 14, 2020
Author Member

Maybe use something like flaky for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.