Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uptest(users): force 10 seconds sleep to improve reliability #1215
Conversation
| time.sleep(10) | ||
| new_user.delete() |
nejch
Oct 13, 2020
Member
I think this should go after, because the delete itself is taking too long:
Suggested change
time.sleep(10)
new_user.delete()
new_user.delete()
time.sleep(10)
Looks like we really need this. I thought my little sidekiq wait hack would work though 🤕 I based it off of this, but I'm not sure if we can extract from the API when this exact sidekiq deletion job is finished:
We can't guarantee when the user will actually be deleted by Sidekiq; this could take a while if the user has a lot of projects/events/etc.
I'll keep looking into this later, maybe we could also just wrap these asserts in retries until the condition is met (with a timeout), since it seems to me like GitLab gets more bloated with new features and so things can take longer with new releases on these little Travis VMs?
They do perform better during the day/office hours though, just retried all the jobs and they're going green 🤣
I think this should go after, because the delete itself is taking too long:
| time.sleep(10) | |
| new_user.delete() | |
| new_user.delete() | |
| time.sleep(10) |
Looks like we really need this. I thought my little sidekiq wait hack would work though
We can't guarantee when the user will actually be deleted by Sidekiq; this could take a while if the user has a lot of projects/events/etc.
I'll keep looking into this later, maybe we could also just wrap these asserts in retries until the condition is met (with a timeout), since it seems to me like GitLab gets more bloated with new features and so things can take longer with new releases on these little Travis VMs?
They do perform better during the day/office hours though, just retried all the jobs and they're going green

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

I'm welcome for better ideas