Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSwift 5 Migration #645
Swift 5 Migration #645
Conversation
|
CI is down :/ |
|
Yes, GitHub changed their default macOS image for their docker environment. Mac is actually outsourced to Orka, and for some reason a couple of weeks ago they changed what their default SDK installs would be. for open source projects, it's not a huge deal, you have to now install any but the default iOS simulator versions for each XCode version, which takes a minute or two. I hit this snag in my commercial repos where the time hit kind of sucks now that we gotta make a value cost for the extra minutes for every push. I'll try to push a fix soon, but this PR would then have to merge or rebase that change. https://www.macstadium.com/orka
|
|
Since your own pod is a pod for the demo app than no. Though you would inhibit all and then use false for just hero. Same difference
Joe Mattiello
________________________________
From: Zonily Jame <[email protected]>
Sent: Thursday, November 28, 2019 7:17:58 AM
To: HeroTransitions/Hero <[email protected]>
Cc: Joseph Mattiello <[email protected]>; Review requested <[email protected]>
Subject: Re: [HeroTransitions/Hero] Swift 5 Migration (#645)
@kuyazee requested changes on this pull request.
________________________________
In Podfile<#645 (comment)>:
@@ -3,7 +3,7 @@
target 'HeroExamples' do
platform :ios, '9.0'
use_frameworks!
- pod 'CollectionKit'
+ pod 'CollectionKit', :inhibit_warnings => true
Shouldn't we inhibit warnings for all pods?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#645?email_source=notifications&email_token=AADBT6BC5QMG366QC2S262LQV6ZHNA5CNFSM4JQ2AYW2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNJ2LJQ#pullrequestreview-324248998>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AADBT6GPFXEUSCC4KLZ3SGTQV6ZHNANCNFSM4JQ2AYWQ>.
|
|
CI fixed in #648 let's rerun the CI after it gets merged |
Signed-off-by: Joe Mattiello <[email protected]>
* Set CI to install sdks * Split out iOS Run Destinations
Signed-off-by: Joseph Mattiello <[email protected]>
Signed-off-by: Joseph Mattiello <[email protected]>
Signed-off-by: Joseph Mattiello <[email protected]>
Signed-off-by: Joseph Mattiello <[email protected]>
Adding a gemfile with some version info helps CI tools know what packages to install or update Signed-off-by: Joseph Mattiello <[email protected]>
…nd readability of tuple
|
I rebased to get CI to run but its broken again haha |
|
Taking a look into the CI issue. -- WIP PR #651 |
I redid the migration as per #594 , it also resolves #611 . Additionally, it added quite a few redundant roundtrip helper functions so I removed them.