Add flow types for browserslist #5340
Conversation
|
flow-libs/browserslist.js.flow
Outdated
| declare module.exports: {| | ||
| (browsers: string | Array<string>): Array<string>, | ||
| parseConfig(configResult: ConfigResult): Promise<?BrowserslistConfig>, | ||
| loadConfig({[path: FilePath]: FilePath, ...}): string, |
There was a problem hiding this comment.
the first argument, options, is defined in browserlist's js api docs: https://github.com/browserslist/browserslist#js-api
| @@ -1,4 +1,5 @@ | |||
| // @flow | |||
| // @flow strict-local | |||
| // flowlint unsafe-getters-setters: off | |||
There was a problem hiding this comment.
@devongovett @mischnic what do you think of allowing getters and setters globally? They do technically introduce potential unsoundness.
There was a problem hiding this comment.
Adds a flow type lib def for
browserslist.Run
yarn flowto ensure that there are no flow errors.@padmaia @wbinnssmith