The Wayback Machine - https://web.archive.org/web/20201123153106/https://github.com/shelljs/shelljs/pull/431
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(make): depreciate shelljs/make #431

Merged
merged 2 commits into from Apr 29, 2016
Merged

chore(make): depreciate shelljs/make #431

merged 2 commits into from Apr 29, 2016

Conversation

@ariporad
Copy link
Contributor

@ariporad ariporad commented Apr 26, 2016

No description provided.

@ariporad ariporad added this to the v0.8.0 milestone Apr 26, 2016
make.js Outdated
@@ -1,5 +1,8 @@
require('./global');

console.log('WARNING: shelljs/make is deprecated, and will be going away soon. You should upgrade ' +
'your code to stop using it. You should also submit feedback at https://git.io/vwgId.');

This comment has been minimized.

@nfischer

nfischer Apr 26, 2016
Member

Could we use the full URL? The shortened URL may appear as less trustworthy.

@nfischer
Copy link
Member

@nfischer nfischer commented Apr 28, 2016

@ariporad I updated the warning output to be a little more concise. I took out the URL, since I'm sure if someone has a concern, they can just post an issue and we can redirect the conversation to the original thread.

@ariporad
Copy link
Contributor Author

@ariporad ariporad commented Apr 29, 2016

LGTM!

@ariporad ariporad merged commit 5a31c7c into master Apr 29, 2016
5 checks passed
5 checks passed
approvals/lgtm this commit looks good
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ariporad ariporad deleted the add-warning-to-make branch Apr 29, 2016
@timburgess
Copy link

@timburgess timburgess commented May 12, 2016

Why is make functionality being deprecated?

@nfischer
Copy link
Member

@nfischer nfischer commented May 12, 2016

@timburgess Please take a look at #340 and we'll continue the conversation there

@shelljs shelljs locked and limited conversation to collaborators May 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.