The Wayback Machine - https://web.archive.org/web/20201127070944/https://github.com/bitwarden/mobile/pull/1152
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include revision date in cipher requests #1152

Merged
merged 1 commit into from Nov 23, 2020

Conversation

@MGibson1
Copy link
Contributor

@MGibson1 MGibson1 commented Nov 17, 2020

Objective

This is a companion PR to API changes found in bitwarden/server#994

Code Changes

  • CipherRequest.cs: Add revision date to request model for validation.
  • CipherService.cs: Include revision date in encryption of ciphers so it can be included in the request model.

Prereqs

@MGibson1 MGibson1 requested a review from bitwarden/dept-engineering Nov 17, 2020
@MGibson1 MGibson1 closed this Nov 23, 2020
@MGibson1 MGibson1 reopened this Nov 23, 2020
@MGibson1 MGibson1 merged commit e27370c into master Nov 23, 2020
5 checks passed
5 checks passed
cloc cloc
Details
android
Details
ios
Details
android-ubuntu android-ubuntu
Details
license/cla Contributor License Agreement is signed.
Details
@MGibson1 MGibson1 deleted the validate-cipher-updates-with-revision-date branch Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.