Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fixes #714 InvalidCastException when using Nullable Reference Types in Options class #715
Conversation
The method syntax of SelectMany (flatmap) is the same as having consecutive `from` statements. Flatmapping over the property info removes the need to to call First()
rubberduck203
added a commit
to rubberduck203/GitNStats
that referenced
this pull request
Nov 23, 2020
There's a bug in the commandline parser library that triggers when an option class has a custom usage function and that function has more than one attribute. When a class has nullable reference type properties, it's members are all tagged with the System.Runtime.CompilerServices.NullableAttribute attribute. Disabling NRTs in just the Options.cs file fixes the bug while still allowing us to use NRTs elsewhere. A bug has been submitted upstream commandlineparser/commandline#714 As well as a pull request that fixes the issue commandlineparser/commandline#715 The compiler directive can be removed once it's accepted and released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.