Please assign me this issue

Hi!

Sorry to hear you're running into an issue. To help us best begin debugging the underlying cause, it is incredibly helpful if you're able to create a minimal reproduction. This is a simplified example of the issue that makes it clear and obvious what the issue is and how we can begin to debug it.

If you're up for it, we'd very much appreciate if you could provide a minimal reproduction and we'll be able to take another look.

Thanks for using Gatsby! 💜

@LekoArts Sir, Can I work on this issue and solve it?

@rutujak24 This issue lacks a clear issue/error description so there isn't anything actionable here. Please have a look at the issues tagged with hacktoberfest.

@rutujak24 I have updated my original message to include information on how to reproduce the error. I didn't create a reproduction since the error is found by simply using a starter project and installing the plugin. There is no special code needed to reproduce the error. I do also include the steps to fix the error. It's a very simple error.

Can you cite a reference stating the protocol should be without a colon? I can't find a reference and everything I find on the canonical tag also has a colon.

Honestly I'm of half a mind to just drop data-basehost and data-baseprotocol. I cannot find any reference that refers to these attributes or how they ought to be filled. These attributes were added two years ago but the PR (#4116) does not explain why. I don't think the original issue (#4110) does either. Perhaps @danhounshell can chime in here?

Before posting the issue, I spend a fair amount of time looking for any specification for data-basehost and data-baseprotocol. I couldn't find any standard or even a reference of anyone who uses those values. Google's documentation does not comment on data-basehost or data-baseprotocol. I also began to wonder if they were really needed.

So I don't have a reference that says the protocol should not have the colon. But I've never seen a reference to the protocol that includes the colon. Plus, I could see how this could have been an oversight by the original programmer. The field parsed.protocol seems to give you exactly what you want. But I've seen people add the .slice(0, -1) function when referencing the protocol from the url package.

Yes I do agree with @mikleing
I had a similar approach to this issue.

Considering it's been like this for two years, I would suggest to either keep it as is or drop it entirely. If nothing is actually using this, they're just dead bytes. And arguably, the protocol of the canonical url should be leading anyways so it feels like a redundant field regardless.

Ok, @pieh pointed me towards https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-canonical-urls/src/gatsby-browser.js#L6-L21 and that this is probably the reason for these attributes existing in the first place. Nothing else. So removing the colon would break that so we're not going to do that.

So I'd propose to drop these attributes and get this information straight from the canonical url in browser.js instead.

@pvdz That sounds like a good plan.

So I'd propose to drop these attributes and get this information straight from the canonical url in browser.js instead.

My PR is pretty much exactly this. :-)

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜