Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix titles case and add missing punctuation marks #28713
Merged
Conversation
|
|
README.md
Outdated
| @@ -15,7 +15,7 @@ Grafana allows you to query, visualize, alert on and understand your metrics no | |||
| - **Alerting:** Visually define alert rules for your most important metrics. Grafana will continuously evaluate and send notifications to systems like Slack, PagerDuty, VictorOps, OpsGenie. | |||
| - **Mixed Data Sources:** Mix different data sources in the same graph! You can specify a data source on a per-query basis. This works for even custom datasources. | |||
|
|
|||
| ## Get started | |||
| ## Get Started | |||
torkelo
Nov 2, 2020
Member
we do not use title case
we do not use title case
achatterjee-grafana
Nov 2, 2020
Collaborator
Correct, we use sentence case.
Please make the following change:
"Mixed data sources" and "Get started".
Correct, we use sentence case.
Please make the following change:
"Mixed data sources" and "Get started".
Rowayda-Khayri
Nov 4, 2020
Author
Contributor
@Rowayda-Khayri was this fixed? Thanks!
"Get Started" was fixed. But "Mixed data sources" wasn't changed in my PR!
@Rowayda-Khayri was this fixed? Thanks!
"Get Started" was fixed. But "Mixed data sources" wasn't changed in my PR!
achatterjee-grafana
Nov 4, 2020
Collaborator
OK - would you want to fix it now or should we do a new PR? Let me know :)
OK - would you want to fix it now or should we do a new PR? Let me know :)
|
Added copy-edit suggestions. |
README.md
Outdated
| @@ -34,10 +34,10 @@ If you're interested in contributing to the Grafana project: | |||
| - Learn how to set up your local environment, in our [Developer guide](/contribute/developer-guide.md). | |||
| - Explore our [beginner-friendly issues](https://github.com/grafana/grafana/issues?q=is%3Aopen+is%3Aissue+label%3A%22beginner+friendly%22). | |||
|
|
|||
| ## Get involved | |||
| ## Get Involved | |||
achatterjee-grafana
Nov 2, 2020
Collaborator
Revert the change.
Revert the change.
Rowayda-Khayri
Nov 4, 2020
Author
Contributor
Done
Done
|
Added a comment. |
README.md
Outdated
| @@ -15,7 +15,7 @@ Grafana allows you to query, visualize, alert on and understand your metrics no | |||
| - **Alerting:** Visually define alert rules for your most important metrics. Grafana will continuously evaluate and send notifications to systems like Slack, PagerDuty, VictorOps, OpsGenie. | |||
| - **Mixed Data Sources:** Mix different data sources in the same graph! You can specify a data source on a per-query basis. This works for even custom datasources. | |||
|
|
|||
| ## Get started | |||
| ## Get Started | |||
|
LGTM! |
ryantxu
added a commit
that referenced
this pull request
Nov 18, 2020
* Fix titles case and add missing punctuation marks * Revert title case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR fixes titles case and adds missing punctuation marks in README.md