The Wayback Machine - https://web.archive.org/web/20201220133842/https://github.com/nficano/python-lambda/issues/83
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click commands should use correct keyword args for requirements #83

Open
karthich opened this issue Dec 5, 2017 · 1 comment
Open

Click commands should use correct keyword args for requirements #83

karthich opened this issue Dec 5, 2017 · 1 comment

Comments

@karthich
Copy link

@karthich karthich commented Dec 5, 2017

The build command in scripts/lambda uses keyword arguments that are inconsistent with the build function in aws_lambda.py
def build(use_requirements, local_package, config_file): aws_lambda.build( CURRENT_DIR, use_requirements=use_requirements, local_package=local_package, config_file=config_file, )
aws_lambda build function signature looks like this:
def build( src, requirements=False, local_package=None, config_file='config.yaml'):

@karthich
Copy link
Author

@karthich karthich commented Dec 5, 2017

Looks like build, deploy, deploy s3 all seem to be using use_requirements key word args. Maybe the aws_lambda function needs to be edited to accomodate these variable name changes?

@karthich karthich changed the title Build command should use correct keyword args for requirements Click commands should use correct keyword args for requirements Dec 5, 2017
karthich pushed a commit to karthich/python-lambda that referenced this issue Dec 5, 2017
nficano added a commit that referenced this issue Jan 4, 2018
Issue: #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.