The Wayback Machine - https://web.archive.org/web/20220111020021/https://github.com/TheAlgorithms/Java/pull/2882
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sort list Algorithm #2882

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Added sort list Algorithm #2882

wants to merge 15 commits into from

Conversation

@siddhant2002
Copy link
Contributor

@siddhant2002 siddhant2002 commented Dec 20, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
siriak
siriak requested changes Dec 20, 2021
View changes
Copy link
Member

@siriak siriak left a comment

No need to include string compare algorithms, please replace main() with tests as in https://github.com/TheAlgorithms/Java/blob/98656cb0cdacd175559272bcbb8bc3b86ddac52a/src/test/java/com/thealgorithms/maths/KaprekarNumbersTest.java and improve formatting

@siddhant2002
Copy link
Contributor Author

@siddhant2002 siddhant2002 commented Dec 22, 2021

@siriak Please check the updated pr

siriak
siriak requested changes Dec 23, 2021
View changes
Copy link
Member

@siriak siriak left a comment

The formatting is much better, but you still need to replace main() with automated tests as mentioned in the previous review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak

@yanglbme yanglbme

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
2 participants
@siddhant2002 @siriak