The Wayback Machine - https://web.archive.org/web/20220320003335/https://github.com/python/cpython/pull/31046
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43721: Fix docstrings for property.getter/setter/deleter #31046

Merged
merged 2 commits into from Mar 14, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Feb 1, 2022

@iritkatriel iritkatriel requested a review from pitrou Feb 1, 2022
Copy link
Member

@pitrou pitrou left a comment

LGTM, but I've never been very acquainted with the property implementation. @rhettinger Do you want to take a look?

@pitrou pitrou requested a review from rhettinger Feb 1, 2022
@iritkatriel iritkatriel requested a review from benjaminp Feb 9, 2022
@iritkatriel iritkatriel merged commit e3d348a into python:main Mar 14, 2022
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 14, 2022

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 14, 2022

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue Mar 14, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Mar 14, 2022

GH-31886 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Mar 14, 2022

GH-31887 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Mar 14, 2022
miss-islington added a commit that referenced this issue Mar 14, 2022
miss-islington added a commit that referenced this issue Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants