Python/JS/Ruby: Shared concepts scaffolding #8476
Merged
+63
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esbena
previously approved these changes
Mar 17, 2022
erik-krogh
reviewed
Mar 17, 2022
javascript/ql/lib/semmle/javascript/internal/ConceptsImports.qll
Outdated
Show resolved
Hide resolved
hmac
previously approved these changes
Mar 22, 2022
| /** | ||
| * Provides Concepts which are shared across languages. | ||
| * | ||
| * Each language will have a language specific `Concepts.qll` file that can import the |
There was a problem hiding this comment.
Suggested change
| * Each language will have a language specific `Concepts.qll` file that can import the | |
| * Each language has a language specific `Concepts.qll` file that can import the |
I think this is clearer to the reader, who might wonder if it describes the current state or some future plan that hasn't yet been realised.
There was a problem hiding this comment.
(also, this direct style matches some rule in our doc style guide)
Co-authored-by: Erik Krogh Kristensen <[email protected]>
erik-krogh
approved these changes
Mar 22, 2022
hmac
approved these changes
Mar 23, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This introduces the base scaffolding from #8307
As mentioned in that PR, the idea is to do separate PRs for each of the concepts we want to share initially, to align on the concept design and query implementation.