Miscellaneous fixes and cleanups #1760
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostmsu
reviewed
Apr 9, 2022
| } | ||
| return Exceptions.RaiseTypeError("invalid object"); |
There was a problem hiding this comment.
I think keeping input parameter validation returns before the main body is a good practice.
| } | ||
|
|
||
| return new EventBinding(self.name, self.reg, new PyObject(ob)).Alloc(); | ||
| return Exceptions.RaiseTypeError("invalid argument"); |
There was a problem hiding this comment.
I agree with this in general, but here this would mean that instead of a single RaiseTypeError with a particular string, we need two, which does not look like an advantage to me.
There was a problem hiding this comment.
I think the old version is easier to read. Nesting makes it harder.
| } | ||
| return Exceptions.RaiseTypeError("invalid target"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What does this implement/fix? Explain your changes.
...
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG