The Wayback Machine - https://web.archive.org/web/20220413052503/https://github.com/pythonnet/pythonnet/pull/1763
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that codec tests are run #1763

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Copy link
Member

@filmor filmor commented Apr 10, 2022

  • Move test_codec.py to the right directory
  • Make PyObjectConversions.Reset public to allow calling it from Python

What does this implement/fix? Explain your changes.

...

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Ensure you have signed the .NET Foundation CLA
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@@ -125,7 +125,7 @@ bool TryDecode(BorrowedReference pyHandle, out object? result)

#endregion

internal static void Reset()
public static void Reset()
Copy link
Member

@lostmsu lostmsu Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method should not be a part of public API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants