The Wayback Machine - https://web.archive.org/web/20220426172241/https://github.com/RustPython/RustPython/issues/3251
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _statistics module containing _normal_dist_inv_cdf #3251

Closed
DimitrisJim opened this issue Oct 8, 2021 · 3 comments · Fixed by #3256
Closed

Add _statistics module containing _normal_dist_inv_cdf #3251

DimitrisJim opened this issue Oct 8, 2021 · 3 comments · Fixed by #3256
Labels
good first issue

Comments

@DimitrisJim
Copy link
Member

@DimitrisJim DimitrisJim commented Oct 8, 2021 •
edited

This should be relatively easy. _statistics needs to be defined as a built-in module and _normal_dist_inv_cdf should be added as its sole function.

_normal_dist_inv_cdf is pretty straight-forward to implement with the C version being a pretty direct translation from the Python version.
@DimitrisJim DimitrisJim added the good first issue label Oct 8, 2021
@DimitrisJim
Copy link
Member Author

@DimitrisJim DimitrisJim commented Oct 8, 2021 •
edited

Basic scaffold for the module (to be placed in stdlib/src):

pub(crate) use _statistics::make_module;

#[pymodule]
mod _statistics {

    #[pyfunction]
    fn _normal_dist_inv_cdf(...) {}
}

it then needs to be exported in stdlib/src/lib.rs in a similar way to other modules.

aDotInTheVoid added a commit to aDotInTheVoid/RustPython that referenced this issue Oct 8, 2021
@aDotInTheVoid
Add _statistics module containing _normal_dist_inv_cd
d898c2b 
Closes RustPython#3251
@aDotInTheVoid aDotInTheVoid mentioned this issue Oct 8, 2021
Merged
@DimitrisJim DimitrisJim changed the title Add _statistics module containing _normal_dist_inv_cd Add _statistics module containing _normal_dist_inv_cdf Oct 9, 2021
@fanninpm
Copy link
Contributor

@fanninpm fanninpm commented Feb 17, 2022 •
edited

@youknowone Now that #3552 is merged, can this be closed?

@djrmarques
Copy link
Contributor

@djrmarques djrmarques commented Mar 18, 2022 •
edited

So this is no longer necessary since the merge mentioned above right?

youknowone pushed a commit to aDotInTheVoid/RustPython that referenced this issue Apr 20, 2022
@aDotInTheVoid @youknowone
Add _statistics module containing _normal_dist_inv_cd
639a4fe 
Closes RustPython#3251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add _statistics module containing _normal_dist_inv_cd aDotInTheVoid/RustPython
3 participants
@DimitrisJim @fanninpm @djrmarques