The Wayback Machine - https://web.archive.org/web/20220502105726/https://github.com/python/cpython/pull/20386
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing example for async functions. #20386

Merged
merged 2 commits into from May 1, 2022
Merged

Conversation

Copy link
Contributor

@Dreamsorcerer Dreamsorcerer commented May 25, 2020

@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented May 25, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Dreamsorcerer

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs awaiting review labels May 25, 2020
@Dreamsorcerer Dreamsorcerer changed the title Add example for async functions. Add typing example for async functions. May 25, 2020
@JelleZijlstra JelleZijlstra requested a review from AlexWaygood Apr 30, 2022
@JelleZijlstra
Copy link

@JelleZijlstra JelleZijlstra commented Apr 30, 2022

This example makes sense but we're trying to move away from using typing.rst for detailed user documentation.

@cpython-cla-bot
Copy link

@cpython-cla-bot cpython-cla-bot bot commented Apr 30, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@AlexWaygood AlexWaygood left a comment

This looks good to me. I think the material on Callable in typing.rst should be moved to typing.readthedocs.io either all at once, or not at all, so this seems like a nice enhancement in the meantime.

@JelleZijlstra JelleZijlstra merged commit 9588f88 into python:main May 1, 2022
13 checks passed
@miss-islington
Copy link

@miss-islington miss-islington commented May 1, 2022

Thanks @Dreamsorcerer for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 1, 2022

GH-92103 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 1, 2022

GH-92104 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 1, 2022
Fixes python/typingGH-424
(cherry picked from commit 9588f880a286a8cc5597188f6ab44108c8f18761)

Co-authored-by: Sam Bull <[email protected]>
miss-islington added a commit that referenced this issue May 1, 2022
miss-islington added a commit that referenced this issue May 1, 2022
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue May 1, 2022
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants