The Wayback Machine - https://web.archive.org/web/20220924043910/https://github.com/scala-native/scala-native/pull/2813
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deep resource embedding on Windows #2813

Merged
merged 2 commits into from Aug 30, 2022
Merged

Fix deep resource embedding on Windows #2813

merged 2 commits into from Aug 30, 2022

Conversation

JD557
Copy link
Contributor

@JD557 JD557 commented Aug 29, 2022

Normalizes all embedded files to use "/" as a path separator when they are embedded.

Fixes #2603

@WojciechMazur WojciechMazur merged commit c61e352 into scala-native:main Aug 30, 2022
59 of 60 checks passed
WojciechMazur pushed a commit to WojciechMazur/scala-native that referenced this issue Aug 31, 2022
@JD557 @WojciechMazur
Fix deep resource embedding on Windows (scala-native#2813)
e9a4fcd 
* Always use the same separator on ResourceEmbedder

* Add a test to check if resources separated with \ are supported

(cherry picked from commit c61e352)
WojciechMazur pushed a commit that referenced this issue Sep 1, 2022
@JD557 @WojciechMazur
Fix deep resource embedding on Windows (#2813)
305f37e 
* Always use the same separator on ResourceEmbedder

* Add a test to check if resources separated with \ are supported

(cherry picked from commit c61e352)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WojciechMazur WojciechMazur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deep resources are incorrectly embedded on Windows
2 participants
@JD557 @WojciechMazur