The Wayback Machine - https://web.archive.org/web/20220830090644/https://github.com/pythonnet/pythonnet/pull/1381
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthly NuGet release previews #1381

Merged
merged 1 commit into from Feb 12, 2021
Merged

Monthly NuGet release previews #1381

merged 1 commit into from Feb 12, 2021

Conversation

lostmsu
Copy link
Member

@lostmsu lostmsu commented Feb 11, 2021

What does this implement/fix? Explain your changes.

This generates monthly release previews on NuGet using GitHub actions

Does this close any currently open issues?

#1379

@lostmsu
Copy link
Member Author

lostmsu commented Feb 12, 2021

Passed, and published https://www.nuget.org/packages/pythonnet/3.0.0-preview21-02-12

I've updated trigger to schedule.

.github/workflows/nuget-preview.yml Outdated Show resolved Hide resolved
.github/workflows/nuget-preview.yml Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
@gpetrou
Copy link
Contributor

gpetrou commented Feb 12, 2021

Would it be possible to also use SignAssembly and AssemblyOriginatorKeyFile for StrongName support?

@lostmsu
Copy link
Member Author

lostmsu commented Feb 12, 2021

@gpetrou you're welcome to contribute that. @filmor do we sign current releases? Where's the key?

@filmor
Copy link
Member

filmor commented Feb 12, 2021

If there is a key, I don't have it. I don't really see what kind of trust we'd establish anyway, being essentially random internet people :)

@lostmsu
Copy link
Member Author

lostmsu commented Feb 12, 2021

@filmor I am assuming they need strong name singing to be able to sign their own libraries, that use ours.

P.S. all open source projects are essentially "random internet people"

@lostmsu
Copy link
Member Author

lostmsu commented Feb 12, 2021

@gpetrou if you really need signed releases, you are welcome to contribute support for that.

@lostmsu lostmsu requested a review from filmor Feb 12, 2021
filmor
filmor approved these changes Feb 12, 2021
@filmor filmor merged commit 6b2347a into master Feb 12, 2021
51 checks passed
@filmor filmor deleted the PR/NuGetMonthly branch Feb 12, 2021
@gpetrou
Copy link
Contributor

gpetrou commented Feb 13, 2021

I have created #1382.
There is already a key in the repository and an associated issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants