Fix layout of NativeTypeSpec on 32 bit platforms
#1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostmsu
force-pushed
the
bugs/32bit-1729
branch
2 times, most recently
from
f02faa9
to
2dd8a66
Compare
filmor
reviewed
Apr 11, 2022
src/runtime/Native/NativeTypeSpec.cs
Outdated
| @@ -10,7 +10,7 @@ struct NativeTypeSpec : IDisposable | |||
| public readonly StrPtr Name; | |||
| public readonly int BasicSize; | |||
| public readonly int ItemSize; | |||
| public readonly TypeFlags Flags; | |||
| public readonly IntPtr Flags; | |||
There was a problem hiding this comment.
Hmm, Flags is clearly defined as a C int, which should "always" be 32bit, right? (https://docs.python.org/3/c-api/type.html#c.PyType_Spec)
lostmsu
force-pushed
the
bugs/32bit-1729
branch
2 times, most recently
from
196f6b6
to
cf91f1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Does this close any currently open issues?
#1729
Checklist
Check all those that are applicable and complete.