The Wayback Machine - https://web.archive.org/web/20201107175215/https://github.com/processing/processing4/pull/99
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users or provide auto-fix when `frame` is used in a sketch #99

Open
wants to merge 1 commit into
base: master
from

Conversation

@urbanskimichal
Copy link

@urbanskimichal urbanskimichal commented May 10, 2020

Work done:

  • Added error message when unrecognised frame occurs during compilation.
  • Added translatable message about the change in editor.
  • Updated editor to show Changes in 4.0 document.

For now I don't think I'm ready for the auto-fix, but can think about it in the future.
This is my first contribution so I'm waiting for suggestions or opinions.

final String undefinedName = args[0];
if (undefinedName.equals("frame")) {
result = Language.interpolate("editor.status.item_removed", undefinedName, "surface");
}

This comment has been minimized.

@sampottinger

sampottinger Jun 29, 2020
Collaborator

Minor request... I think we have been doing } else {

@@ -1310,6 +1310,12 @@ static public void showChanges() {
}
}

static public void showChangesV4() {

This comment has been minimized.

@sampottinger

sampottinger Jun 29, 2020
Collaborator

Thank you so much for this @urbanskimichal! What are your thoughts on replacing showChanges outright?

This comment has been minimized.

@sampottinger

sampottinger Jul 1, 2020
Collaborator

Actually how about doing a showChangesV3 and showChangesV4 (same for handleCrustyCode). See urbanskimichal#2.

@sampottinger
Copy link
Collaborator

@sampottinger sampottinger commented Jul 1, 2020

I made the above changes ahead of an integration branch build. It's ok if we go a different direction. See urbanskimichal#2. Thank you again @urbanskimichal!

@sampottinger
Copy link
Collaborator

@sampottinger sampottinger commented Jul 7, 2020

This is available on an integration branch at https://github.com/sampottinger/processing4 (master) for testing in the context of other open PRs with a community build at https://www.datadrivenempathy.com/processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.