The Wayback Machine - https://web.archive.org/web/20230303054600/https://github.com/nodegit/nodegit/pull/1945
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag createWithSignature function #1945

Merged
merged 3 commits into from Nov 21, 2022

Conversation

julianmesa-gitkraken
Copy link
Contributor

Fix tag createWithSignature function
Also tests fixed

lib/tag.js Outdated Show resolved Hide resolved
@julianmesa-gitkraken
Copy link
Contributor Author

@ianhattendorf Changed createWithSignature using async/await.
Also added a test to show the deprecation warning.

Added a test to verify deprecation warning
Copy link
Member

@ianhattendorf ianhattendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the deprecation message 👍

@ianhattendorf ianhattendorf merged commit a381c0b into nodegit:master Nov 21, 2022
12 checks passed
weedz pushed a commit to weedz/nodegit that referenced this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants