The Wayback Machine - https://web.archive.org/web/20230103121437/https://github.com/expo/expo/pull/18669
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(repo): add star gif to readme #18669

Merged
merged 2 commits into from Aug 18, 2022
Merged

feat(repo): add star gif to readme #18669

merged 2 commits into from Aug 18, 2022

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Aug 16, 2022 •
edited

Why

Add a gif to the bottom of the readme which reminds users to star the repo with a lot of fanfare.

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Aug 16, 2022
@EvanBacon EvanBacon marked this pull request as ready for review Aug 16, 2022
@Simek
Copy link
Collaborator

Simek commented Aug 16, 2022 •
edited

I like the idea, but I don't like the quality of the gif (and especially preview still). 🤷‍♂️

Can try to achieve better quality with custom setting using Kap on macOS or LICEcap on Win tomorrow.

Screenshot 2022-08-16 225905

@brentvatne
Copy link
Member

brentvatne commented Aug 16, 2022

I like the idea, but I don't like the quality of the gif (and especially preview still). 🤷‍♂️

Can try to achieve better quality with custom setting using Kap on macOS or LICEcap on Win tomorrow.

Screenshot 2022-08-16 225905

I quite like Gifski for this: https://apps.apple.com/ca/app/gifski/id1351639930?mt=12

@EvanBacon
Copy link
Contributor Author

EvanBacon commented Aug 17, 2022

@Simek this was made with Kap filming this pen https://codepen.io/EvanBacon/full/BarGmqO feel free to retry if you'd like

@Simek
Copy link
Collaborator

Simek commented Aug 17, 2022 •
edited

tloop

I think this looks better, but is it only me, or the labels are misaligned?

@brentvatne
Copy link
Member

brentvatne commented Aug 17, 2022

yeah the labels on the left seem to not quite have the same y position

@EvanBacon
Copy link
Contributor Author

EvanBacon commented Aug 18, 2022

@Simek I updated the alignment in the pen

@Simek
Copy link
Collaborator

Simek commented Aug 18, 2022

@EvanBacon Updated GIF below.

tloop2

Simek
Simek approved these changes Aug 18, 2022
View changes
Copy link
Collaborator

@Simek Simek left a comment

LGTM! 👍

Btw. I wasn't aware that you can overwrite the motion setting in your GH account, so the GIFs plays automatically again after latest accessibility changes. Happy to have autoplay back. 😉

Screenshot 2022-08-18 170824

@EvanBacon EvanBacon merged commit 4baf711 into main Aug 18, 2022
1 check passed
@EvanBacon EvanBacon deleted the @evanbacon/repo/readme-star-cta branch Aug 18, 2022
Ddv0623 pushed a commit to preciofishbone/expo that referenced this pull request Sep 26, 2022
@EvanBacon @Ddv0623
feat(repo): add star gif to readme (expo#18669)
a83eaec 
* Update README.md

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simek Simek

@brentvatne brentvatne

@amandeepmittal amandeepmittal

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EvanBacon @Simek @brentvatne @expo-bot