Bug fix and translation

Resolved Venutius
(@venutius)

1 month ago

Hi there, on line 185 of class-admin-settings.php, Almaweb, needs to become upper case.

Also, I can complete your English translation if you like?

This is a lovely plugin.

Viewing 4 replies - 1 through 4 (of 4 total)

Plugin Author AlmaWeb
(@almawebdev)

1 month ago

Hi Venutius,

I’ve just released version 1.1.1, which now includes all the fixes that were previously only available in trunk.

You should be able to update the plugin and get the corrected version right away.

Please feel free to let me know if you notice any missing translations or if you have any feedback or ideas regarding the functionality, i’d be very happy to hear them.

Thanks again for your help and for the kind words.

Thread Starter Venutius
(@venutius)

1 month ago

cool, I will check it out.
Thread Starter Venutius
(@venutius)

1 month ago
There is another bug, I think it is a refactoring omission.

In class-business-kpis you have not defined $table_name, or set it as $this->table_name.

This is fine for most of the functions, which have that variable set in the function. but one function has not, and it throws a db error. it looks like you were in the middle of that refactor but got distracted and never got back to it. Something I do all of the time 🙂
- This reply was modified 1 month ago by Venutius.
Plugin Author AlmaWeb
(@almawebdev)

1 month ago

You’re absolutely right, thank you for the detailed analysis.
It was indeed a refactoring omission, and that specific function was still relying on an undefined $table_name, which caused the database error.

I’ve just released version 1.1.2 to address this issue as a critical fix.

Thanks again for taking the time to dig into the code and point this out, it’s very much appreciated !

Viewing 4 replies - 1 through 4 (of 4 total)

You must be logged in to reply to this topic.