Skip to content

8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 14, 2024

Hi all,

This pull request contains a backport of commit d636e0d3 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 9 Oct 2024 and was reviewed by Andrew Haley, Johan Sjölen and Julian Waters.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8341688 needs maintainer approval

Issue

  • JDK-8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1048/head:pull/1048
$ git checkout pull/1048

Update a local copy of the PR:
$ git checkout pull/1048
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1048/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1048

View PR using the GUI difftool:
$ git pr show -t 1048

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1048.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 0be27bf0c5227582ce184dde6fc5530198a50bf6 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 14, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 14, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to generate comments in -XX:+PrintInterpreter to link to source code for RISC-V, this will be usefull to debug the inperpreter. Only change the PrintInterpreter output, risk is low.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@sendaoYan
8341688: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 14, 2024
@sendaoYan
Copy link
Member Author

Thanks for the approved.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@sendaoYan
Your change (at version 951305b) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 17, 2024

Going to push as commit 3fc07f2.
Since your change was applied there have been 29 commits pushed to the master branch:

  • 27d2abe: 8320892: AArch64: Restore FPU control state after JNI
  • fe4b0fa: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled
  • dd4e0ae: 8341261: Tests assume UnlockExperimentalVMOptions is disabled by default
  • f19e69a: 8342014: RISC-V: ZStoreBarrierStubC2 clobbers rflags
  • 70eff9d: 8340109: Ubsan: ciEnv.cpp:1660:65: runtime error: member call on null pointer of type 'struct CompileTask'
  • 6ed940b: 8320682: [AArch64] C1 compilation fails with "Field too big for insn"
  • fbfe11f: 8341024: [test] build/AbsPathsInImage.java fails with OOM when using ubsan-enabled binaries
  • f766080: 8320397: RISC-V: Avoid passing t0 as temp register to MacroAssembler:: cmpxchg_obj_header/cmpxchgptr
  • 8e19c8f: 8339386: Assertion on AIX - original PC must be in the main code section of the compiled method
  • f9070df: 8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter
  • ... and 19 more: https://git.openjdk.org/jdk21u-dev/compare/eb6a23aec3fbab1bcf10975583c9c062953de2b3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 17, 2024
@openjdk openjdk bot closed this Oct 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 17, 2024
@openjdk
Copy link

openjdk bot commented Oct 17, 2024

@phohensee @sendaoYan Pushed as commit 3fc07f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants