[CALCITE-3627] New Row Null Policy #2667
Conversation
|
Finally I created a clean pr. @DonnyZone I look forward your comments. So sorry to create multiple PRs |
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
Outdated
Show resolved
Hide resolved
|
Some tests in |
@DonnyZone previous Calcite does not support ROW nullability. so for those failing tests row is null but it returns full row rather than null value for row. I changed tests' expected output with right one. Please let me know if you see any issue |
|
LGTM! |
DonnyZone
added
the
LGTM-will-merge-soon
|
@DonnyZone I believe I squashed my commits. Please let me know if you need anything from me. |
Sorry for the inconvenience, could you squash your 5 commits into one, i.e., " |
talatuyarer
force-pushed
the
CALCITE-3627-new-row-nullpolicy
branch
from
dd6e72d to
008a33d
Compare
|
Ok it is done. Now I see only one commit @DonnyZone |
|
Hi @talatuyarer, sorry for trouble you again. The ticket number in commit message should be |
talatuyarer
force-pushed
the
CALCITE-3627-new-row-nullpolicy
branch
from
008a33d to
ba74249
Compare
|
@DonnyZone it is done I did not realized too 😂 |
|
Thank you @DonnyZone for reviewing and merging 🙏 |
As describe under CALCITE-3627 ticket. Current row policy is wrong. When ROW has a null column. Calcite returns null for ROW value. I am working on Apache Beam SQL Row support. Because of ANY policy RexToLixTranslator generate wrong code. This is my first pr for calcite project. Thanks for your comments in advance.
I recreated my pr because old pr did not puck up updated code.
@DonnyZone could you re-review ? I updated my pr after your RexNode-to-Expression CodeGen Implementation.
Thanks