Skip to content

[MRESOURCES-291] CopyResourcesMojo and TestResourcesMojo is NOT thread-safe #134

@jira-importer

Description

@jira-importer

Jin Xu opened MRESOURCES-291 and commented

If you try to make several sub-projects using this plugin to copy resources from some folter to a same folder, or even overwriting some files, it would crush.
I don't think this be thread-safe.
I see the codes. you are using File.mkdirs, which is actually not thread-safe. also, you are using file writing functions, which is not thread safe if multiple threads trying to write to a same file.
So I don't think it is good to annote these 2 mojos as thread-safe.
Please either remake that part, or remove the thread-safe annotation.
Or simply add a synchronized to that function might also be acceptable.


No further details from MRESOURCES-291

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpriority:majorMajor loss of function

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions