Don't branch in tryReadFirstTwoBytesU64

swolchok · facebook-github-bot · commit 95976e1fcd0a · 2024-03-04T23:40:51.000-08:00
Summary: We were trying to save an AND, but ANDs are essentially free so the work the generated code was doing to save the AND was not worth it.

Reviewed By: davidtgoldblatt

Differential Revision: D54504159

fbshipit-source-id: 3ccc7882123036d9616c5257cb8cd0c497f8dec7
diff --git a/thrift/lib/cpp/util/VarintUtils-inl.h b/thrift/lib/cpp/util/VarintUtils-inl.h
@@ -134,12 +134,8 @@ FOLLY_ALWAYS_INLINE bool tryReadFirstTwoBytesU64(
   // maximum size an encoded varint can be.
   DCHECK((p[0] & 0x80) != 0);
   uint64_t hi = p[1];
-  if ((hi & 0x80) == 0) {
-    result = (hi << 7) | (p[0] & 0x7f);
-    return true;
-  }
   result = ((hi & 0x7F) << 7) | (p[0] & 0x7f);
-  return false;
+  return (hi & 0x80) == 0;
 }
 
 #if THRIFT_UTIL_VARINTUTILS_SIMD_DECODER
