Skip to content

[BE] bump test dependency z3-solver to drop using deprecated pkg_resources #158905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

[ghstack-poisoned]
@XuehaiPan XuehaiPan requested review from a team and jeffdaily as code owners July 23, 2025 05:49
Copy link

pytorch-bot bot commented Jul 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158905

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 8345472 with merge base d3f9107 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 23, 2025
@XuehaiPan XuehaiPan requested review from malfet and albanD July 23, 2025 05:50
@XuehaiPan XuehaiPan added better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request labels Jul 23, 2025
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang are you the right person to know what these dynamo test do and if it's ok to update the expecttest?

@@ -251,13 +251,13 @@ def fn(x, shape):

Model:
==> L['shape'][0]: 0
==> L['shape'][1]: 1
==> L['shape'][2]: 1
==> L['shape'][1]: 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks suspicious.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not intrinsically suspicious; there are many models Z3 can find and it's not required for it to always produce the same result.

@ezyang
Copy link
Contributor

ezyang commented Jul 23, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source release notes: releng release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants