-
Notifications
You must be signed in to change notification settings - Fork 24.8k
[BE] bump test dependency z3-solver
to drop using deprecated pkg_resources
#158905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158905
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 8345472 with merge base d3f9107 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…esources` ghstack-source-id: d351593 Pull-Request: pytorch#158905
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ezyang are you the right person to know what these dynamo test do and if it's ok to update the expecttest?
@@ -251,13 +251,13 @@ def fn(x, shape): | |||
|
|||
Model: | |||
==> L['shape'][0]: 0 | |||
==> L['shape'][1]: 1 | |||
==> L['shape'][2]: 1 | |||
==> L['shape'][1]: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks suspicious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not intrinsically suspicious; there are many models Z3 can find and it's not required for it to always produce the same result.
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
setuptools>=77
to enable PEP 639 #158104z3-solver
to drop using deprecatedpkg_resources
#158905cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela