drivers: stepper: introduce stepper_drv.h for stepper_drv apis #101001
+255
−245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jilaypandya
force-pushed
the
refactor/stepper_drv.h
branch
from
a1dc6fc to
dc289da
Compare
henrikbrixandersen
requested changes
Dec 14, 2025
Member
henrikbrixandersen
left a comment
henrikbrixandersen
left a comment
There was a problem hiding this comment.
This is nothing like what the CAN driver subsystem does (or any other driver subsystem for that matter).
What's the rationale behind this?
Member
Author
|
Ahh okay, i found the recent split that we introduced in Stepper driver subsystem i.e. Stepper (Stepper Controller) and Stepper-DRV (Stepper driver) highly analogous to how CAN Controller and CAN Transceiver APIs are structured. But maybe i am missing out on something :) |
following the approach of transceiver.h in can driver subsystem, refactoring stepper_drv apis to stepper_drv.h Signed-off-by: Jilay Pandya <[email protected]>
jilaypandya
force-pushed
the
refactor/stepper_drv.h
branch
from
dc289da to
aa14231
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following the approach of transceiver.h in can driver subsystem, refactoring stepper_drv apis to stepper_drv.h