Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
1.39.0
Description
follow https://issues.apache.org/jira/browse/CALCITE-6959
Currently RelShuttle also do not support LogicalRepeatUnion (I also had check for other Logical Type, seems remain LogicalRepeatUnion need to support) :
- LogicalRepeatUnion is not overridden for accept(RelShuttle shuttle) ;
- RelShuttle#visit not support for LogicalRepeatUnion ;
so follow test would not work:
@Test void testRelShuttleForLogicalRepeatUnion() { final String sql = "WITH RECURSIVE delta(n) AS (\n" + "VALUES (1)\n" + "UNION ALL\n" + "SELECT n+1 FROM delta WHERE n < 10\n" + ")\n" + "SELECT * FROM delta"; final RelNode rel = sql(sql).toRel(); final List<RelNode> rels = new ArrayList<>(); final RelShuttleImpl visitor = new RelShuttleImpl() { @Override public RelNode visit(LogicalRepeatUnion repeatUnion) { RelNode visitedRel = super.visit(repeatUnion); rels.add(visitedRel); return visitedRel; } }; rel.accept(visitor); assertThat(rels, hasSize(1)); assertThat(rels.get(0), instanceOf(LogicalRepeatUnion.class)); }
others in Logic seams OK for it, need a pr to fix it.
Attachments
Issue Links
- Blocked
-
CALCITE-6959 Support LogicalAsofJoin in RelShuttle
-
- Closed
-
- is related to
-
CALCITE-7090 Add RepeatUnion override for RelHomogeneousShuttle
-
- Resolved
-
- links to