Page MenuHomePhabricator

Missing composer.json patch causes upgrade failures
Closed, ResolvedPublicBUG REPORT

Description

Hi,

I'm currently migrating an Wiki running on an older Ubuntu 22.04 machine with mediawiki running as a debian package version 1.35.6-1 onto the mediawiki docker image on
https://hub.docker.com/_/mediawiki , docker.io/library/mediawiki latest 31482c1fd830 (which asks to report bugs here)

and tried to update the database as described on
https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script

and do get

/var/www/html# php maintenance/run.php update.php
MediaWiki 1.42.4 Updater

wikimedia/parsoid: 0.19.1 installed, 0.19.0 required.

Error: your composer.lock file is not up to date. Run "composer update --no-dev" to install newer dependencies

So the versions put together for the docker image don't seem to match.

regards

Event Timeline

Thanks for raising awareness for this, this is a known issue as a change (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1082844) that would have been important did not make it into "1.42.4".

We also ran into this problem in Arch Linux, although not in a docker context: https://gitlab.archlinux.org/archlinux/infrastructure/-/merge_requests/901#note_232829

I already have a fix pending for the docker image: https://github.com/wikimedia/mediawiki-docker/pull/152

ChristianHeusel renamed this task from Version missmatch in mediawiki docker image to Missing composer.json patch causes upgrade failures.Dec 27 2024, 8:38 AM
ChristianHeusel triaged this task as High priority.

I ran into this too. Can't run the update script.

I have to question why 1.42.4 was released with this issue. If you cannot run the update script, then the release is broken. Now, you need to spin 1.42.5 to fix this issue.

A intermediate fix for the docker images is on it's way and just waiting for review & merge from the Docker Inc. team: https://github.com/docker-library/official-images/pull/18170

Note that my experience was a patch upgrade from 1.42.3 to 1.42.4, not using a docker image.

So is there another patch release for the 1.42 series planned soon? It would be good to get this properly fixed for everyone. 😅