Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdguard would be good next to pihole #622
Comments
Dear, adguard: What am I missing here? |
It looks like you have everything, but I can't tell if the indentation is correct. You can use markdown code blocks like this ``` |
unfortunately it's not working for me. I will wait, maybe when you guys have a time.. :) |
Now that I'm in front of a PC I was able to review what you posted a little more and see the indentation by editing your comment (didn't actually edit it, just pressed the edit button to see what you had). Please use proper code blocks in the future as it won't require me to use the edit comment feature to see your indentation. you have: adguard:
image: adguard/adguardhome
container_name: adguard
hostname: ${DOCKERHOSTNAME}
restart: unless-stopped
logging:
driver: json-file
options:
max-file: ${DOCKERLOGGING_MAXFILE}
max-size: ${DOCKERLOGGING_MAXSIZE}
volumes:
- /home/norbert/./docker/config/adguardhome/work:/opt/adguardhome/work
- /home/norbert/./docker/config/adguardhome/conf:/opt/adguardhome/conf
ports:
- "3000:3000" which looks to be incorrect with the volumes. I would recommend: adguard:
image: adguard/adguardhome
container_name: adguard
hostname: ${DOCKERHOSTNAME}
restart: unless-stopped
logging:
driver: json-file
options:
max-file: ${DOCKERLOGGING_MAXFILE}
max-size: ${DOCKERLOGGING_MAXSIZE}
volumes:
- /home/norbert/.docker/config/adguardhome/work:/opt/adguardhome/work
- /home/norbert/.docker/config/adguardhome/conf:/opt/adguardhome/conf
ports:
- "3000:3000" Or use the DOCKERCONFDIR variable like you see in the templates in this repo. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Keep this. Sorry haven't had time yet. I've got something in the works that will make adding apps a bit cleaner for the future, once that's in I'll be looking at adding apps. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Keep this |
Shall I give a go? |
Yeah, it should be very similar to pihole |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
https://hub.docker.com/r/adguard/adguardhome