The Wayback Machine - https://web.archive.org/web/20200616062606/https://github.com/GhostWriters/DockSTARTer/issues/622
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adguard would be good next to pihole #622

Open
noorbertt opened this issue Mar 31, 2019 · 13 comments
Open

Adguard would be good next to pihole #622

noorbertt opened this issue Mar 31, 2019 · 13 comments

Comments

@nemchik nemchik added this to To do in Apps via automation Mar 31, 2019
@nemchik nemchik added the enhancement label Mar 31, 2019
@noorbertt
Copy link
Author

@noorbertt noorbertt commented Apr 1, 2019

Dear,
Could you help me a bit please?
I was try to setup adguard with compose file, but something wrong:

adguard:
image: adguard/adguardhome
container_name: adguard
hostname: ${DOCKERHOSTNAME}
restart: unless-stopped
logging:
driver: json-file
options:
max-file: ${DOCKERLOGGING_MAXFILE}
max-size: ${DOCKERLOGGING_MAXSIZE}
volumes:
- /home/norbert/./docker/config/adguardhome/work:/opt/adguardhome/work
- /home/norbert/./docker/config/adguardhome/conf:/opt/adguardhome/conf
ports:
- "3000:3000"

What am I missing here?

@nemchik
Copy link
Member

@nemchik nemchik commented Apr 1, 2019

It looks like you have everything, but I can't tell if the indentation is correct. You can use markdown code blocks like this

```
multi
line
code
```

@noorbertt
Copy link
Author

@noorbertt noorbertt commented Apr 3, 2019

unfortunately it's not working for me. I will wait, maybe when you guys have a time.. :)

@nemchik
Copy link
Member

@nemchik nemchik commented Apr 3, 2019

Now that I'm in front of a PC I was able to review what you posted a little more and see the indentation by editing your comment (didn't actually edit it, just pressed the edit button to see what you had). Please use proper code blocks in the future as it won't require me to use the edit comment feature to see your indentation.

you have:

adguard:
    image: adguard/adguardhome
    container_name: adguard
    hostname: ${DOCKERHOSTNAME}
    restart: unless-stopped
    logging:
      driver: json-file
      options:
        max-file: ${DOCKERLOGGING_MAXFILE}
        max-size: ${DOCKERLOGGING_MAXSIZE}
    volumes:
       - /home/norbert/./docker/config/adguardhome/work:/opt/adguardhome/work
       - /home/norbert/./docker/config/adguardhome/conf:/opt/adguardhome/conf
    ports:
      - "3000:3000"

which looks to be incorrect with the volumes. I would recommend:

adguard:
    image: adguard/adguardhome
    container_name: adguard
    hostname: ${DOCKERHOSTNAME}
    restart: unless-stopped
    logging:
      driver: json-file
      options:
        max-file: ${DOCKERLOGGING_MAXFILE}
        max-size: ${DOCKERLOGGING_MAXSIZE}
    volumes:
       - /home/norbert/.docker/config/adguardhome/work:/opt/adguardhome/work
       - /home/norbert/.docker/config/adguardhome/conf:/opt/adguardhome/conf
    ports:
      - "3000:3000"

Or use the DOCKERCONFDIR variable like you see in the templates in this repo.

@stale
Copy link

@stale stale bot commented Jun 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 2, 2019
@nemchik
Copy link
Member

@nemchik nemchik commented Jun 2, 2019

Keep this. Sorry haven't had time yet. I've got something in the works that will make adding apps a bit cleaner for the future, once that's in I'll be looking at adding apps.

@stale stale bot removed the wontfix label Jun 2, 2019
@stale
Copy link

@stale stale bot commented Aug 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 1, 2019
@nemchik
Copy link
Member

@nemchik nemchik commented Aug 1, 2019

Keep this

@stale stale bot removed the wontfix label Aug 1, 2019
@mouzzampk2014
Copy link

@mouzzampk2014 mouzzampk2014 commented Sep 4, 2019

Shall I give a go?

@nemchik
Copy link
Member

@nemchik nemchik commented Sep 5, 2019

Yeah, it should be very similar to pihole

@stale
Copy link

@stale stale bot commented Nov 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 4, 2019
@nemchik nemchik removed the wontfix label Dec 4, 2019
@github-actions
Copy link

@github-actions github-actions bot commented Feb 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

@github-actions github-actions bot commented Apr 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Apps
  
To do
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.