The Wayback Machine - https://web.archive.org/web/20200615042724/https://github.com/topics/codereview
Skip to content
#

codereview

Here are 76 public repositories matching this topic...

JeffreyDing11223
JeffreyDing11223 commented Nov 11, 2018

unit test coverage is always 0% , even the log shows that "Linter:UnitTest over".

command:
goreporter -p ./ -r /Users/jeffrey -f html
log:

2018/11/11 19:33:45 The template path is not specified,and will use the default template
2018/11/11 19:33:45 There are no packages that are excepted, review all items of the package
2018/11/11 19:33:45 Linter:CountCode over,time consumi

grempe
grempe commented Nov 4, 2016

As requested, I am pointing to a comment you solicited regarding some improvements I would suggest for dawnscanner. The improvements are:

  • Document all scans that are performed, grouping them by type of scan and detailing what they scan
  • Consider not using a centralized scan directory at the top level of the user home dir
  • Document the scan results DB and dir structure

For original com

waigani
waigani commented Nov 5, 2018

lingo run docs --debug panics:

panic: close of nil channel

goroutine 20 [running]:
github.com/codelingo/codelingo/sdk/flow.(*flowRunner).setHelp.func1(0xb19280, 0xc4200be008, 0xac6e21, 0x3cb, 0xa4c000, 0x10edf60)
	/home/jesse/go/src/github.com/codelingo/codelingo/sdk/flow/cli.go:89 +0x1a7
github.com/codelingo/codelingo/vendor/github.com/urfave/cli.ShowAppHelp(0xc4200c91e0, 0xc4200b
Indomitable
Indomitable commented Jan 21, 2020

Hi,
First I want to say this is good idea which can be very useful.
One thing that I found is that in the "Merge Request's Changes" diff is generated between the base commit and HEAD, but it should be between target branch and HEAD.
The command git diff target-branch...merge-request-branch gives exactly what we need.

The problem is visible if there is a long running MR with

Improve this page

Add a description, image, and links to the codereview topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the codereview topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.