The Wayback Machine - https://web.archive.org/web/20200718073355/https://github.com/mojs/mojs/issues/211
Skip to content

/ mojs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependencies #211

Open
DanielRuf opened this issue May 24, 2019 · 3 comments
Open

Fix dependencies #211

DanielRuf opened this issue May 24, 2019 · 3 comments
Assignees
@xavierfoucrier
Labels
core
Projects
mojs@next
Milestone
v1.0.0

Comments

@DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented May 24, 2019

After changing "git+https://github.com/legomushroom/grock.git" to legomushroom/grock we still have some issues with other dependencies:

error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads ssh://[email protected]/Nikku/node-browserify.git
Directory: /Users/druf/projects/mojs
Output:
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

6878 silly resolveWithNewModule [email protected] checking installable status
6879 silly fetchPackageMetaData error for browserify@github:Nikku/node-browserify#local-fix Error while executing:

6882 silly saveTree ├─┬ [email protected]
6882 silly saveTree │ ├── [email protected]
6882 silly saveTree │ ├── [email protected]
6882 silly saveTree │ ├── [email protected]
6882 silly saveTree │ ├── [email protected]
6882 silly saveTree │ └── [email protected]

So it seems karma-browserify > watchify is the culprit.
@xavierfoucrier
Copy link
Member

@xavierfoucrier xavierfoucrier commented May 24, 2019 •
edited

Hi @DanielRuf,

Yes, of course all dependencies need to be updated on this project, many are deprecated but we are still working on the website with @Sandstedt. If you want to PR something, it is more than welcome 😉

Seems that you already have a PR in the pipe: #186
@DanielRuf
Copy link
Contributor Author

@DanielRuf DanielRuf commented May 24, 2019

Seems that you already have a PR in the pipe: #186

Right but I have to check against the current state again as we have no lockfile.
https://travis-ci.org/mojs/mojs/builds/368854050

We should probably pin the dependencies in package.json then as lockfiles are not used on npmjs and when adding / installing dependencies - just the root lockfile actually locks.
@xavierfoucrier
Copy link
Member

@xavierfoucrier xavierfoucrier commented Jun 5, 2019

I agree with you, we need to have a package-lock.json file in order to properly have dependencies pinned.

I am very busy since 1 month, but if you are able to make a new PR or update the existing one, don't hesitate to ping me on the Slack channel 😉
@xavierfoucrier xavierfoucrier added the core label Jun 18, 2019
@xavierfoucrier xavierfoucrier changed the title Failing CI due to SSH remote URLs in dependencies Fix dependencies Jul 8, 2019
@xavierfoucrier xavierfoucrier self-assigned this Jul 8, 2019
@xavierfoucrier xavierfoucrier pinned this issue Jul 30, 2019
@xavierfoucrier xavierfoucrier added this to Core in mojs@next Feb 13, 2020
@xavierfoucrier xavierfoucrier mentioned this issue Apr 27, 2020
Merged
@xavierfoucrier xavierfoucrier linked a pull request that will close this issue Apr 27, 2020
Dependencies upgrade #238
Merged
xavierfoucrier added a commit that referenced this issue Apr 30, 2020
@xavierfoucrier
Merge pull request #238 from mojs/dependencies-upgrade
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
3e646fe 
Dependencies upgrade. This fix #211.
@xavierfoucrier xavierfoucrier added this to the v1.0.0 milestone Jul 3, 2020
@xavierfoucrier xavierfoucrier unpinned this issue Jul 3, 2020
xavierfoucrier added a commit that referenced this issue Jul 8, 2020
@xavierfoucrier
Merge pull request #239 from mojs/tests
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
00190b1 
This close #211.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xavierfoucrier xavierfoucrier

Labels
core
Projects
mojs@next
Core
Milestone
v1.0.0
Linked pull requests

Successfully merging a pull request may close this issue.

Dependencies upgrade
2 participants
@DanielRuf @xavierfoucrier
You can’t perform that action at this time.